Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] CRM_Core_Exception incorrectly called without message #22339

Merged
merged 1 commit into from
Dec 29, 2021

Conversation

braders
Copy link
Contributor

@braders braders commented Dec 29, 2021

Overview

CRM_Core_Exception requires at least 1 argument - $message. This was missing in one scenario, therefore a message has been added.

Comments

The language used in the message matches language used elsewhere within this class.

@civibot
Copy link

civibot bot commented Dec 29, 2021

(Standard links)

@civibot civibot bot added the master label Dec 29, 2021
@demeritcowboy
Copy link
Contributor

I see the other string isn't ts'd either and it's normal to leave out ts for strings that are rarely seen by users, I'm just wondering how often this one comes up. But if you wanted to use ts(), then I'd say make the phrase identical to the other string since it actually is about "contact id" in both cases.

@braders
Copy link
Contributor Author

braders commented Dec 29, 2021

I see the other string isn't ts'd either and it's normal to leave out ts for strings that are rarely seen by users, I'm just wondering how often this one comes up. But if you wanted to use ts(), then I'd say make the phrase identical to the other string since it actually is about "contact id" in both cases.

As this issue hasn't been spotted before now I'd be inclined to assume the Exception is rarely thrown, and therefore keep it untranslated, unless you'd prefer otherwise.

@demeritcowboy
Copy link
Contributor

The exception is only about a year old, but ok let's just keep as is for now.

@demeritcowboy demeritcowboy merged commit 78c122b into civicrm:master Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants