Add workflow template classes for contributions #22340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
wktemplates
branch
2 times, most recently
from
c0d60ce
to
a615297
Compare
totten
reviewed
Dec 30, 2021
| /** | ||
| * @method array getContribution() | ||
| * @method array getContact() | ||
| * @method $this setContact(array $contact) |
There was a problem hiding this comment.
Agree this PR looks safe / consistent / starting-place for other revisions. 👍
I was about to hit "Merge" but then wondered about this fragment - contact is a property of GenericWorkflowMessage not ContributionTrait.
There is another property in this trait, contributionId -- should it reference that instead?
* @method ?int getContributionId()
* @method $this setContributionId(?int $contributionId)
eileenmcnaughton
force-pushed
the
wktemplates
branch
from
a615297
to
baf1d7a
Compare
|
@totten you are right - I just updated to use contribution ID & updated one variable in one template to rely on that (plus test) to verify it |
eileenmcnaughton
force-pushed
the
wktemplates
branch
from
baf1d7a
to
66c8a61
Compare
|
opps thanks @totten |
|
Test fail is unrelated (date calc on the cusp of the new year - already started badly!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add workflow template classes for contributions
Before
A big void
After
Tada
Technical Details
These aren't doing much of anyting yet - but they set up the structure - which will allow us to start to add in values to the trait (& remove some of those issets which mess with escaping)
Comments