Remove unnecessary id attribute.

[braders]

Overview

The min_amount ID was used for both a tr and a input element, breaking the accessibility link between the label and input elements.

Before

The "Minimum Amount" label was not semantically linked with the appropriate input element due to a duplicate ID. The duplicate ID has been removed. This is on the settings page for a single price set. (civicrm/admin/price?action=update&sid=123)

After

The duplicate ID attribute been removed.

Technical Details

There are a handful of JS references to the min_amount ID. However, these all apply to other templates, and all assume that #min_amount is an input element (for example, because they read or write the elements value property).

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Thanks @braders that makes sense.
I think test failures are unrelated. @civicrm-builder retest this please.

[colemanw]

@braders I think it would be safer to leave financial_type_id_row alone as it's not hurting anything. I agree it's unused in civicrm-core but it may have been added for the sake of an extension - there are a few financial extensions out there that do alterations to forms like this one.

[braders]

@braders I think it would be safer to leave financial_type_id_row alone as it's not hurting anything. I agree it's unused in civicrm-core but it may have been added for the sake of an extension - there are a few financial extensions out there that do alterations to forms like this one.

That's fair. I've re-pushed, and updated the PR description to match.

[colemanw]

@civicrm-builder retest this please