Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not escape showHideBlocks by default #22371

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Do not escape showHideBlocks by default #22371

merged 1 commit into from
Jan 5, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

imageOverview

Do not escape showHideBlocks by default

Affects civicrm/acl?action=add&reset=1

Before

imageAfter

image

Technical Details

Comments

@eileenmcnaughton
Do not escape showHideBlocks by default
570eb11 
Affects civicrm/acl?action=add&reset=1
@civibot
Copy link

civibot bot commented Jan 5, 2022

(Standard links)

@civibot civibot bot added the master label Jan 5, 2022
@colemanw
Copy link
Member

colemanw commented Jan 5, 2022

It's a travesty that this ancient showHideBlocks is still a thing in 2022.

@eileenmcnaughton
Copy link
Contributor Author

@colemanw totally - but I don't feel excited about removing it

@colemanw colemanw merged commit d3e1db7 into civicrm:master Jan 5, 2022
@colemanw colemanw deleted the acl2 branch January 5, 2022 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eileenmcnaughton @colemanw @seamuslee001