dev/report#90 - Don't crash search_kit on upgrade from 5.35

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/report/-/issues/90
Running extension upgrades crashes if you upgrade search kit directly from 5.35 or earlier to 5.40 or later and have an existing search_display. Note that 5.35 was a security release so there are still lots of sites on 5.35 (http://stats.civicrm.org/?tab=sites)

Before

1. Install 5.35.2 and enable search kit.
2. Create a search with a display and save it.
3. Upgrade to e.g. 5.44.0. The civi upgrade itself runs ok.
4. Visit the system status page and run the extension upgrades.
5. Error about "acl_bypass doesn't exist" because upgrade_1001 triggers something that doesn't exist until upgrade_1005.

After

Ok

Technical Details

While the right thing might be to do as suggested in https://docs.civicrm.org/dev/en/latest/framework/upgrade/#tips-prefer-simple-sql-semantics-over-apibaodao and rewrite the upgrade steps without using apis, this seems a simpler fix.

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).