[REF] Remove handling for relationshipID

[eileenmcnaughton]

Overview

[REF] Remove handling for relationshipID

Before

This function is only called from one place and that place does not pass in $params['id'] - however there is a shonk-load of handling 'just in case'

After

poof

Technical Details

$relationshipParams in these lines is where id is NOT passed in from

civicrm-core/CRM/Contact/BAO/Contact/Utils.php

Lines 284 to 292 in e995b80

	// create employee of relationship
	$relationshipParams = [
	'is_active' => TRUE,
	'relationship_type_id' => $relTypeId . '_a_b',
	'contact_check' => [$organization => TRUE],
	];
	[$valid, $invalid, $duplicate, $saved, $relationshipIds]
	= self::legacyCreateMultiple($relationshipParams, $contactID);

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

test this please