Crash when adding a relationship when CiviMember is disabled #22451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
...I guess I'm not sure whether to post this against the RC? It's two versions back but is also clearly a regression. |
|
test this please |
|
Jenkins re test this please |
|
@MegaphoneJon this definitely should be against 5.46, but it needs rebasing. |
totten
force-pushed
the
member-count-fix
branch
from
30aa796
to
b83d85d
Compare
|
@colemanw @MegaphoneJon It looks like there was one commit. I rebased it on top of d72538b (which is shared history for master+5.46 - so it should be agreeable about merging to either branch). |
|
Confirmed this fix is correct 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
See https://lab.civicrm.org/dev/core/-/issues/3025 for a full explanation. This is a regression introduced in 5.43.
Before
Relationship is added, but with error
Key id not found in api results(in Civi 5.45) orMembershipType API is not available because CiviMember component is disabled(Civi 5.47).After
Relationship added, no error.
Comments
I considered adding more conditionals for other components, but this problem doesn't seem to manifest on other components - most likely because only adding a relationship is the only way for these counts to change without taking an action that would require the component to be enabled (e.g. adding a membership changes the membership count, but requires CiviMember be enabled).