SearchKit - Facilitate popup forms #22490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
colemanw
force-pushed
the
refreshButton
branch
from
9350a99
to
ccb9f55
Compare
This expands the listener to the entire surrounding <form> element, in case there are related popups on the Afform.
…when clicking an element
colemanw
force-pushed
the
refreshButton
branch
from
ccb9f55
to
f1b93a4
Compare
|
I tested this in conjunction with the mosaico PR and it works well merging |
colemanw
added a commit
to JMAConsulting/uk.co.vedaconsulting.mosaico
that referenced
this pull request
Jan 13, 2022
Bumping version requirement because this depends on civicrm/civicrm-core#22490
colemanw
added a commit
to JMAConsulting/uk.co.vedaconsulting.mosaico
that referenced
this pull request
Jan 13, 2022
Bumping version requirement because this depends on civicrm/civicrm-core#22490
colemanw
added a commit
to JMAConsulting/uk.co.vedaconsulting.mosaico
that referenced
this pull request
Jan 14, 2022
Bumping version requirement because this depends on civicrm/civicrm-core#22490
colemanw
added a commit
to JMAConsulting/uk.co.vedaconsulting.mosaico
that referenced
this pull request
Feb 1, 2022
Bumping version requirement because this depends on civicrm/civicrm-core#22490
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This adds two bits of utility code to facilitate adding a popup form to an Afform containing a Search Display.
Technical Details
crmDialogPopupdirective makes it possible to invoke an Angular popup form without any extra controller code (works much nicer with Afforms).Comments
This is required by #22467 and veda-consulting-company/uk.co.vedaconsulting.mosaico#478