Centralise skipColumnHeader to one function (fixes notices, cleans code) #23135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Centralise skipColumnHeader to one function (fixes notices, cleans code)
Before
Notices & duplicated code on preview screen for import
After
Preview screen still handles the column headers (error is due to csv missing date data)
Technical Details
This adds a parent class that allows the preview screen (and soon other screens in the flow) to access values submitted on the first screen in the flow - much of the confusion in this code is because of the way in which values are passed from form to form - however the quick form layer is already storing and caching this so we don't need another layer to pass the values on top
Comments