Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralise skipColumnHeader to one function (fixes notices, cleans code) #23135

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Apr 8, 2022

Overview

Centralise skipColumnHeader to one function (fixes notices, cleans code)

Before

Notices & duplicated code on preview screen for import

After

Preview screen still handles the column headers (error is due to csv missing date data)

image

Technical Details

This adds a parent class that allows the preview screen (and soon other screens in the flow) to access values submitted on the first screen in the flow - much of the confusion in this code is because of the way in which values are passed from form to form - however the quick form layer is already storing and caching this so we don't need another layer to pass the values on top

Comments

@civibot
Copy link

civibot bot commented Apr 8, 2022

(Standard links)

@colemanw
Copy link
Member

Ok, this code cleanup makes sense and @eileenmcnaughton's going to be doing more followups in this area so it should get run multiple times this release cycle.

@colemanw colemanw merged commit 5779a1a into civicrm:master Apr 11, 2022
@colemanw colemanw deleted the memm branch April 11, 2022 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants