Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send group subscription welcome email only if template is enabled #23139

Merged

Conversation

kurund
Copy link
Contributor

@kurund kurund commented Apr 8, 2022

@civibot
Copy link

civibot bot commented Apr 8, 2022

(Standard links)

@civibot civibot bot added the master label Apr 8, 2022
@jaapjansma
Copy link
Contributor

test this please

@jaapjansma
Copy link
Contributor

  • General standards
    • Explain (r-explain)
      • PASS : The goal/problem/solution have been adequately explained in issue.
    • User impact (r-user)
      • PASS: The change would be intuitive or unnoticeable for a majority of users who work with this feature.
    • Documentation (r-doc)
      • PASS: The changes do not require documentation.
    • Run it (r-run)
      • ISSUE: We did test this in the test environment of this PR. Everything seems to work. However the test environment has CIVICRM_MAIL_LOG defined so we are not able to test whether the e-mail gets send or whether it returns in an error.
  • Developer standards
    • Technical impact (r-tech)
      • PASS: The change preserves compatibility with existing callers/code/downstream.
    • Code quality (r-code)
      • PASS: The functionality, purpose, and style of the code seems clear+sensible.
    • Maintainability (r-maint)
      • PASS: The change is trivial enough that it does not require tests.
    • Test results (r-test)
      • PASS: The test results are all-clear.

@kurund do you think there is any risk with merging this without testing the actual mail?

@kurund
Copy link
Contributor Author

kurund commented Apr 13, 2022

@jaapjansma

I have tested with actual mailings and it is working as expected.

@jaapjansma
Copy link
Contributor

@eileenmcnaughton or @colemanw can of you merge this PR? We believe it is safe to merge this.

@jaapjansma jaapjansma added the merge ready PR will be merged after a few days if there are no objections label Apr 13, 2022
@eileenmcnaughton eileenmcnaughton merged commit d37776a into civicrm:master Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master merge ready PR will be merged after a few days if there are no objections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants