Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce use of reference #23165

Merged
merged 1 commit into from
Apr 11, 2022
Merged

Reduce use of reference #23165

merged 1 commit into from
Apr 11, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Reference does not make sense for objects. assign_by_ref does not make
sense when not used again in the function or returned in a reffy kinda way

@eileenmcnaughton
Reduce use of reference
8de8eb1 
Reference does not make sense for objects. assign_by_ref does not make
sense when not used again in the function or returned in a reffy kinda way
@civibot
Copy link

civibot bot commented Apr 11, 2022

(Standard links)

@civibot civibot bot added the master label Apr 11, 2022
@colemanw colemanw merged commit d584d41 into civicrm:master Apr 11, 2022
@colemanw colemanw deleted the ref branch April 11, 2022 23:24
@colemanw
Copy link
Member

I must admit I have no idea the purpose of assign_by_ref() - is there ever a legitimate reason to use it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @colemanw