(NFC) Skip CliRunnerTest on php80+drush+Backdrop #23184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There seems to be a problem in using `drush ev` with our current versions of Drush / Backdrop / PHP 8.0
```
[bknix-edge:~/bknix/build/bcmaster/web/modules/civicrm] drush ev 'echo 123;'
PDOException: SQLSTATE[HY093]: Invalid parameter number: number of bound variables does not match number of tokens: SELECT name FROM {system} WHERE type=&civicrm#39;module&civicrm#39; AND status=1; Array
(
[:type] => module
[:status] => 1
)
in drush_db_select() (line 131 of phar:///Users/totten/bknix/extern/drush8.phar/includes/dbtng.inc).
Drush command terminated abnormally due to an unrecoverable error.
```
The problem is not specific to the functionality `civicrm-core.git` -- it
affects anything going through `drush-backdrop` and seems to be blocked on
upstream fixes. But it's been generating a bunch of red-dot noise for the
past few months, and there's no point in that.
Note that `CliRunnerTest` still provides coverage for several adjacent combinations, so I'm not
too concerned about substantive change affecting civicrm-core. Those adjacent combinations are:
* PHP80 + D7 + Drush (differ only by CMS)
* PHP80 + Backdrop + Cv (differ only by CLI-runner)
* PHP7x + Bacdkrop + Drush (differ only by PHP-version)
|
(Standard links)
|
totten
changed the title
totten
changed the title
|
Changed to "NFC" because (1) it only changes the test and (2) the test-scenario never passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The
CliRunnerTestgoes through various permutations of CLI commands (cv,drush,wp-cli) in different environments (php7/min,php8/max, D7, D9, BD, WP, etc). The permutation forphp8+backdrop+drushhas been failing persistently (https://test.civicrm.org/job/CiviCRM-E2E-Matrix/).Skip this test permutation. It is blocked by upstream issues in drush-backdrop, and (AFAIK) this permutation has never worked.
CC @seamuslee001 @herbdool
Before
These tests fail in php8+backdrop+drush:
After
The tests are skipped in php8+backdrop+drush.
Technical Details
The problem does not seem to be specific to the functionality
civicrm-core.git-- it appears to affect anything going throughdrush-backdropon php8, and it's been blocked on upstream fixes. You can see this by running justdrush ev:I'm not too worried about losing coverage here -
CliRunnerTeststill provides coverage for several adjacent configurations, ieComments
It's hard to see this when skimming the matrix (https://test.civicrm.org/job/CiviCRM-E2E-Matrix/), but there is an additional error for
backdrop,maxregardingSoapTest. I haven't been able to reproduce this yet. I mention it only to show why these extra red-flags matter -- when we get multiple+persistent red-flags for something outside our control, we're less likely to see other red-flags.When/if there's an upstream fix, we can re-enable the test...