Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ref] [Import] [csv] Remove non-functional code #23195

Merged
merged 1 commit into from
Apr 20, 2022
Merged

[Ref] [Import] [csv] Remove non-functional code #23195

merged 1 commit into from
Apr 20, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Remove non-functional code

Before

Instantiating the importJob with a table name and no createTable
does nothing but set the name so that getTableName() gets it

  • import_table_name is always set so these lines do nothing

image

After

poof

Technical Details

Comments

@eileenmcnaughton
Remove non-functional code
9c03e6c 
Instantiating the importJob with a table name and no createTable
does nothing but set the name so that getTableName() gets it
- import_table_name is always set so these lines do nothing
@civibot
Copy link

civibot bot commented Apr 14, 2022

(Standard links)

@civibot civibot bot added the master label Apr 14, 2022
@eileenmcnaughton eileenmcnaughton changed the title Remove non-functional code [Ref] [Import] [csv] Remove non-functional code Apr 17, 2022
@colemanw colemanw merged commit 86058be into civicrm:master Apr 20, 2022
@colemanw colemanw deleted the ds3 branch April 20, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @colemanw