Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Do not pass form properties within the form #23213

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

[REF] Do not pass form properties within the form

This function was obviously separated from shared code - so
now we can use this within the function....

Before

$this passed to protected non-static function

After

the function accesses $this itself

Technical Details

I also made it private to be even clearer that it is only used in this form

Comments

@civibot
Copy link

civibot bot commented Apr 15, 2022

(Standard links)

@civibot civibot bot added the master label Apr 15, 2022
This function was obviously separated from shared code - so
now we can use this within the function....
@colemanw
Copy link
Member

Makes sense.

@colemanw colemanw merged commit 2e89bdd into civicrm:master Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants