Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardise activity datasource text #23217

Merged
merged 1 commit into from
Apr 17, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Apr 15, 2022

Overview

Standardise activity datasource text - this applies the same text standardisations figured out on Membership & Contribution to Activity

Before

After

image

Technical Details

Comments

In trying to work through the activity form I discovered an html difference in terms of a 'heading' for upload data file

image

vs

image

So am looking for input as to which to standardise on. Here is contact: - shich suggests 'go with the headings but add in 'Import Options' too - it's likely the Select datasource will be extended to the other imports (I kinda hate it but if one has it they might as well all have it & it is permission-restricted)

image

image

image

image

@civibot
Copy link

civibot bot commented Apr 15, 2022

(Standard links)

@civibot civibot bot added the master label Apr 15, 2022
@colemanw
Copy link
Member

IMO the header is redundant, but I don't really care that much.

@colemanw colemanw merged commit 0bc523b into civicrm:master Apr 17, 2022
@colemanw colemanw deleted the import_act branch April 17, 2022 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants