Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(REF) CryptoRegistry - Fix type declaration #23220

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

totten
Copy link
Member

@totten totten commented Apr 15, 2022

Overview

Tighten/fix type-signature.

Before

The Container has inaccurate metadata about the type of crypto.registry. It claims type CryptoService, but that type doesn't exist. (That was an older/interim name used during drafting.) The true type is CryptoRegistry.

$ cv ev 'echo get_class(Civi::service("crypto.registry"));'
Civi\Crypto\CryptoRegistry

After

Correct type.

Comments

AFAIK, this is entirely asymptomatic. The use of factory-method means that the declared-type is basically not used at runtime.

So this is just a small tidy-up.

@civibot
Copy link

civibot bot commented Apr 15, 2022

(Standard links)

@civibot civibot bot added the master label Apr 15, 2022
@totten totten changed the title (REF) CryptoRegistry - Tighten type declaration (REF) CryptoRegistry - Fix type declaration Apr 15, 2022
@eileenmcnaughton eileenmcnaughton merged commit dea1584 into civicrm:master Apr 15, 2022
@totten totten deleted the master-defn branch April 15, 2022 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants