Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ref] [Import] Remove another 'in-between' class #23221

Merged
merged 1 commit into from
Apr 17, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Remove another 'in-between' class

As with Contribution & Membership there is a pointless in-between class that
is only inherited by one class...

Before

CRM_Activity_Import_Parser_Activity functions distributed between that class and it's unshared parent-class CRM_Activity_Import_Parser

After

Parent removed, functions moved to CRM_Activity_Import_Parser_Activity

Technical Details

Comments

@civibot
Copy link

civibot bot commented Apr 15, 2022

(Standard links)

@civibot civibot bot added the master label Apr 15, 2022
As with Contribution & Membership there is a pointless in-between class that
is only inherited by one class...
@eileenmcnaughton eileenmcnaughton changed the title Remove another 'in-between' class [Ref] [Import] Remove another 'in-between' class Apr 17, 2022
@colemanw
Copy link
Member

Merging, it's the same cleanup as the others.

@colemanw colemanw merged commit bc1ed25 into civicrm:master Apr 17, 2022
@colemanw colemanw deleted the mapField branch April 17, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants