Update copied event reminders to link to new event when creating from… #23238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
ufundo
force-pushed
the
event-reminders-from-template-api4
branch
3 times, most recently
from
deee83d
to
8207169
Compare
|
style warning.. - see https://test.civicrm.org/job/CiviCRM-Core-PR/48118/checkstyle/ |
… template using api4
ufundo
force-pushed
the
event-reminders-from-template-api4
branch
from
8207169
to
0045993
Compare
|
fixed the style issues 👍 |
|
@agileware-justin @agileware-fj - I feel like you use Event Templates & might be able to comment - note @ufundo is a relatively new contributor so I was going to go easy on the 'test please' bit :-) |
|
@eileenmcnaughton if you or someone else could help with #23098 (comment) - then sure happy to review this one. |
|
Thanks E. Testing now... |
|
@ufundo good work, tested and confirmed working. 🏅 @eileenmcnaughton ready to roll. 👍
|
|
thanks @agileware-justin ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… template using api4
Overview
A fix for https://lab.civicrm.org/dev/core/-/issues/3183
Comments
The code around this is very hard to follow so wasn't able to get my head around how it was supposed to work... hence this somewhat inelegant approach.