Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managed entity cleanup #23251

Merged
merged 2 commits into from
Apr 20, 2022
Merged

Managed entity cleanup #23251

merged 2 commits into from
Apr 20, 2022

Conversation

colemanw
Copy link
Member

Overview

Further code cleanup per discussion on #22959

Before

Class variables, which confusingly persist in the singleton, but rebuilt every time.

After

Simplified as local variables.

@civibot
Copy link

civibot bot commented Apr 19, 2022

(Standard links)

@totten
Copy link
Member

totten commented Apr 20, 2022

These changes look pretty sensible, and there's a fair amount of test-coverage hitting this code.

@totten totten merged commit 7fb563c into civicrm:master Apr 20, 2022
@colemanw colemanw deleted the managedEntityCleanup branch April 20, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants