[REF] [Import] Remove another good intention from the import class #23261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@eileenmcnaughton can the Retest this please |
|
@colemanw I think all tests might be mysteriously failing at the moment |
|
@colemanw civihr has the same dumb pattern in it so on the off chance the import code I'm looking at in there still works I guess removing the constant would break it.... |
|
civibot, test this please |
|
test this please |
eileenmcnaughton
changed the title
|
@colemanw this is passing now |
Once upon a time - the import classes were written.... Back then it seemed like a good idea to give the derived classes a way to abort processing. Like unicorns and mermaids derived classes turned out to be mythical creatures - not even found by searching the git universe....
|
@colemanw was there anything outstanding on this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once upon a time - the import classes were written....
Back then it seemed like a good idea to give the derived classes
a way to abort processing.
Like unicorns and mermaids derived classes turned out to
be mythical creatures - not even found by searching the
git universe....