[Import] Rename dedupe rule id field from dedupe to dedupe_rule_id field #23263
Conversation
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
import_wippier
branch
from
e82448f
to
8d361a4
Compare
|
This PR is well-documented and includes test coverage. I think we should just merge it as it's part of ongoing refactoring and we want it all within the same release cycle. |
colemanw
added
the
merge ready
|
I will be continuing to follow up on this & extend test cover - so getting this merged opens that up & the r-run will be ongoing over the top of this - failure seems still related to general fails but try again jenkins - test this please |
|
Between all the test mahem this got a fail into it - which is in the PR it builds on - based on the merge-ready on this PR/ discussion I merged the PR that is passing & am rebasing & fixing the middle PR to get this back to passing - note the test failures relate to the tests rather than issues from this change |
eileenmcnaughton
force-pushed
the
import_wippier
branch
2 times, most recently
from
4df19b3
to
91e41fc
Compare
…import This provides a bit of sanity to the MapTable.tpl which is included from MapField and Preview - the focus being around getting rid of all the section tags which rely on Count being assigned and getting back to for-eaching the relevant arrays
It is still dedupe internally as those places will 'age out'
eileenmcnaughton
force-pushed
the
import_wippier
branch
from
91e41fc
to
dfa2f16
Compare
|
test this please |
Overview
[Import] Rename dedupe rule id field from dedupe to dedupe_rule_id field
Builds on other open prs - if they are merged this can be rebased down....
Before
The field name for 'dedupe_rule_id' is 'dedupe;
After
Renamed to 'dedupe_rule_id' in the Contact flow - It is still dedupe internally as those places will 'age out'
Technical Details
A universe search showed that @mlutfy's advanced import extension refers to the form value (which is unchanged in this PR) - however, I think it's probably best that once this piece of work is all merged I work with @mlutfy to update advanced import as there are a bunch of things it does where core code could be leveraged - e.g the 'dedupe' value is saved to
civicrm_advimport- but that will be redundant as submitted_values are being saved to the newcivicrm_user_jobonce the open PRs are merged.so advimport can access from there.Comments
Builds on #23245 and #23260 - can be rebased when that is merged (or that will close when this is is merged)