dev/user-interface#47 Disable scrolling on time inputs

[mlutfy]

Overview

The time widgets used by CiviCRM are a bit sensitive. Combined to the fact that we often have rather long forms (ex: Event Management), an admin can easily accidentally change the time of an event.

To reproduce:

• Go to Event > New Event
• Scroll on the page
• scroll over a time widget (ex: time of the event)

notice how the time was changed.

I feel like this is not useful at all, because the scrolling is super sensitive, and I find it pretty hard to really set the right time using scrolling.

https://lab.civicrm.org/dev/user-interface/-/issues/47

Before

After

Scrolling over the time input will scroll the page, but not the time.

Technical Details

Widget docs: http://keith-wood.name/timeEntry.html

Comments

A few users complained about this. The scrolling time makes them very uncomfortable about accidentally breaking things.

Drupal9 devs testing this need to run composer so that the /libraries folder is updated as well.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

I'm OK with this change. Maybe the reason it hasn't been raised before is because scroll-on-hover is a linux thing. On Mac/Win systems I'm pretty sure the input element would need to be focused before the scroll wheel would affect it.

[eileenmcnaughton]

I had an internal ticket to fix this back when we upgraded to 4.4....

[mlutfy]

I had reports from users on Windows. Maybe the behaviour changed in recent Windows versions?

I'm not sure why the tests are failing. I see maybe stuff like this:

20 04 2022 06:28:41.728:INFO [karma-server]: Karma v6.3.17 server started at http://localhost:9876/
20 04 2022 06:28:41.730:INFO [launcher]: Launching browsers PhantomJS with concurrency unlimited
20 04 2022 06:28:41.734:INFO [launcher]: Starting browser PhantomJS
20 04 2022 06:28:42.071:INFO [PhantomJS 2.1.1 (Linux x86_64)]: Connected on socket jtlNlfsuj2h9XLeAAAAB with id 18734001
........................................................................
ALERT: 'Error
The scheduled date and time is in the past'
ALERT: 'Error
The scheduled date and time is in the past'
.
ALERT: 'Error
The scheduled date and time is in the past'
........
PhantomJS 2.1.1 (Linux x86_64): Executed 81 of 81 SUCCESS (1.04 secs / 0.993 secs)
Found EXITCODES=""

[mlutfy]

jenkins, test this please

[colemanw]

@mlutfy all PR tests are failing at the moment. Might be an issue with the server?

[demeritcowboy]

It's a windows thing too. It's also the cause of mysterious crashes when you go to edit a contribution and don't realize you've accidentally set a time for the receipt date but not a date part.

[totten]

civibot, test this please

[eileenmcnaughton]

@colemanw opps test fails relate to the PR I merged

Test Result (3 failures / +3)
api\v4\SearchDisplay\SearchSegmentTest.testRangeSearchSegment
api\v4\SearchDisplay\SearchSegmentTest.testSegmentCustomField
api\v4\SearchDisplay\SearchSegmentTest.testSegmentCalcField