Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ref] [Import] Cleanup cleanup on old tables for form re-submission #23276

Merged
merged 1 commit into from
May 4, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Cleanup cleanup on old tables for form re-submission

Before

The form needs to know about the table name

After

Responsibility is with the dataSource - the data source flushes the table, and the table is explicity flushed when it's clear the form is being re-submitted rather than in a hidden magic place

Technical Details

Comments

@civibot
Copy link

civibot bot commented Apr 21, 2022

(Standard links)

@civibot civibot bot added the master label Apr 21, 2022
@eileenmcnaughton eileenmcnaughton changed the title Cleanup cleanup on old tables for form re-submission [Ref] [Import] Cleanup cleanup on old tables for form re-submission Apr 21, 2022
@colemanw
Copy link
Member

colemanw commented May 4, 2022

OK, test coverage looks solid.

@colemanw colemanw merged commit 462c243 into civicrm:master May 4, 2022
@colemanw colemanw deleted the flush branch May 4, 2022 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants