Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare currencies as well as amounts on template Contribution change #23298

Merged

Conversation

artfulrobot
Copy link
Contributor

Overview

Follow up from #21473

if the currency is the only thing that has changed, e.g. it's in as 10USD but should be 10GBP, then the comparison will not pick it up since we pass only one currency in the comparator function, so 10 === 10, i.e. unchanged.

Before

Change currency on template contribution; Contribution Recur unchanged.

After

Change currency on template contribution; Contribution Recur changed.

@civibot
Copy link

civibot bot commented Apr 25, 2022

(Standard links)

@civibot civibot bot added the master label Apr 25, 2022
Update CRM/Contribute/BAO/ContributionRecur.php
@eileenmcnaughton eileenmcnaughton merged commit ada6a5f into civicrm:master Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants