Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] [Import] [Trivial] Make 'mapper' field available as a submittable value throughout the flow #23308

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Apr 26, 2022

Overview

[REF] [Import] [Trivial] Make 'mapper' field available as a submittable value throughout the flow

Before

The submitted value for mapper (and doGeocodeAddress) needs to be passed from form to form within the flow

After

It can be accessed from any form in the flow using $this->getSubmittedValue('mapper')

Technical Details

The fields defined here can be accessed from any field in
the flow, removing the need to pass the values from form to form - this array tells it which form in the flow the values would have been submitted on

Comments

Getting this merged will mean that this change can be re-based out of other PRs & will reduce conflicts

…le value throughout the flow

The fields defined here can be accessed from any field in
the flow, removing the need to pass the values from form to form
@civibot
Copy link

civibot bot commented Apr 26, 2022

(Standard links)

@eileenmcnaughton
Copy link
Contributor Author

@demeritcowboy are you able to MOP this too? It doesn't do anything as yet but more than one PR uses a variant of this (it will make them go stale but I'l rebase)

@demeritcowboy demeritcowboy merged commit 67f1753 into civicrm:master Apr 26, 2022
@eileenmcnaughton eileenmcnaughton deleted the import_fields branch April 26, 2022 23:18
@eileenmcnaughton
Copy link
Contributor Author

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants