PR 22070 follow-up: reinstate respecting no_display on report column headers #23321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
Merged
|
@davejenx I'm fine with this - but it might be better agains the 5.49rc? |
|
Merging this so it doesn't miss the next rc - but we could still backport if you want @davejenx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
PR 22070 included a change that stopped the no_display property being respected on report column headers. This PR addresses that. Discussed at #22070 (comment) .
Before
Before PR 22070, the no_display property was respected on report column headers.
After PR 22070, the no_display property was no longer respected.
After
After this PR, the no_display property is again respected.