Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import fixes - regression + rename on upgrade #23333

Closed
wants to merge 8 commits into from

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented May 1, 2022

Overview

@demeritcowboy this is the 2 mentioned PRs in the same PR - seems they don't conflict

#23329
#23288

Note there are some sample files attached to https://lab.civicrm.org/dev/core/-/issues/3414 for testing

I did get conflicts with #23292

UPDATE - I fixed conflicts to pull in #23292 - which means the bulk can be r-run together & either merged together in full or some part/s can be merged

@civibot civibot bot added the master label May 1, 2022
@civibot
Copy link

civibot bot commented May 1, 2022

(Standard links)

@demeritcowboy
Copy link
Contributor

CRM_Contact_Import_Form_MapFieldTest::testSubmit with data set "save_mapping" (array('new mapping', 'save it', 1), array(array('do_not_import'), array('first_name'), array('last_name'), array('street_address', 2)), array(array('mapping', 1, array('new mapping')), array('mapping_field', 4, array(), array(array('do_not_import'), array('first_name'), array('last_name'), array('street_address', 2)))))
TypeError: CRM_Import_Parser::getUserJob(): Return value must be of type array, null returned

/home/jenkins/bknix-dfl/build/core-23333-1qoge/web/sites/all/modules/civicrm/CRM/Import/Parser.php:85
/home/jenkins/bknix-dfl/build/core-23333-1qoge/web/sites/all/modules/civicrm/CRM/Import/Parser.php:98
/home/jenkins/bknix-dfl/build/core-23333-1qoge/web/sites/all/modules/civicrm/CRM/Import/Parser.php:113
/home/jenkins/bknix-dfl/build/core-23333-1qoge/web/sites/all/modules/civicrm/CRM/Contact/Import/Parser/Contact.php:3560
/home/jenkins/bknix-dfl/build/core-23333-1qoge/web/sites/all/modules/civicrm/CRM/Contact/Import/Form/MapField.php:624
/home/jenkins/bknix-dfl/build/core-23333-1qoge/web/sites/all/modules/civicrm/CRM/Contact/Import/Form/MapField.php:600
/home/jenkins/bknix-dfl/build/core-23333-1qoge/web/sites/all/modules/civicrm/CRM/Contact/Import/Form/MapField.php:560
/home/jenkins/bknix-dfl/build/core-23333-1qoge/web/sites/all/modules/civicrm/tests/phpunit/CRM/Contact/Import/Form/MapFieldTest.php:65

@eileenmcnaughton
Copy link
Contributor Author

thanks @demeritcowboy - will fix now & rebase

@eileenmcnaughton
Copy link
Contributor Author

That should pass now - I'll check in on the sub-pr

@eileenmcnaughton
Copy link
Contributor Author

closing since #23288 merged in the mean time

@eileenmcnaughton eileenmcnaughton deleted the import_all branch May 3, 2022 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants