-
-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import fixes - regression + rename on upgrade #23333
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Standard links)
|
|
thanks @demeritcowboy - will fix now & rebase |
The datasource stores the table name on the job - we don't need to pass it around. Also - stop cleaning up the temp table at the end - we want it to output results but will add a cleanup routine later
eileenmcnaughton
force-pushed
the
import_all
branch
from
May 2, 2022 00:50
25ae791
to
c1d6afb
Compare
That should pass now - I'll check in on the sub-pr |
closing since #23288 merged in the mean time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
@demeritcowboy this is the 2 mentioned PRs in the same PR - seems they don't conflict
#23329
#23288
Note there are some sample files attached to https://lab.civicrm.org/dev/core/-/issues/3414 for testing
I did get conflicts with #23292
UPDATE - I fixed conflicts to pull in #23292 - which means the bulk can be r-run together & either merged together in full or some part/s can be merged