[Ref] [Import] Add extra functions to DataSource #23344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
changed the title
|
test this please |
eileenmcnaughton
force-pushed
the
import_functions
branch
from
dc9add7
to
7c195e0
Compare
eileenmcnaughton
commented
May 3, 2022
| if ($limit) { | ||
| $query .= ' LIMIT ' . $limit . ($offset ? (' OFFSET ' . $offset) : NULL); | ||
| } | ||
| public function getRows(bool $nonAssociative = TRUE): array { |
There was a problem hiding this comment.
Function was only just added so we can change the signature - only one call to it now - https://github.com/civicrm/civicrm-core/pull/23263/files#diff-4f0a1c0d1f7a02c448ebe273bd5b951a1811dd14949b11b9c8914b2c198fcebaR384
eileenmcnaughton
force-pushed
the
import_functions
branch
2 times, most recently
from
59c4a2c
to
a518d6f
Compare
This adds functions from civicrm#23292 to the DataSource class (without them being called as yet) - part of trying to get to the point where fixes are not dependent on each other
eileenmcnaughton
force-pushed
the
import_functions
branch
from
a518d6f
to
46a7c32
Compare
|
test this please |
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add extra functions to DataSource
Before
The functions that multiple cleanups rely on keep causing PR conflicts
After
This adds functions from #23292 to
the DataSource class (without them being called as yet)
Technical Details
These functions are not called - except for one which is slightly refactored but in tested code
Comments
\