Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor function simplification in private function #23364

Merged
merged 1 commit into from
May 5, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented May 4, 2022

Overview

Minor function simplification in private function

Before

Function checks for duplicates & early-returns if they are found

After

Parent checks for duplicates & calls function if they are not found

Technical details

The function does 2 different things depending on whether if finds a duplicate
& having it in a sub-function doesn't make the parent class clearer....

The function does 2 different things depending on whether if finds a duplicate
& having it in a sub-function doesn't make the parent class clearer....
@civibot
Copy link

civibot bot commented May 4, 2022

(Standard links)

@colemanw
Copy link
Member

colemanw commented May 4, 2022

Refactor makes sense

@eileenmcnaughton eileenmcnaughton merged commit 9f74a34 into civicrm:master May 5, 2022
@eileenmcnaughton eileenmcnaughton deleted the rel branch May 5, 2022 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants