Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] [Import] extract validation functionality #23371

Merged
merged 1 commit into from
May 5, 2022
Merged

[REF] [Import] extract validation functionality #23371

merged 1 commit into from
May 5, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented May 5, 2022 •
edited
Loading

Overview

[REF] [Import] extract validation functionality

Before

Summary function does some validation & some wrangling - mixed up

After

Validation extracted to validateValues

Technical Details

I'm gonna stop calling summary in a bit - but this is a straight extraction

Comments

@civibot
Copy link

civibot bot commented May 5, 2022

(Standard links)

@civibot civibot bot added the master label May 5, 2022
@eileenmcnaughton eileenmcnaughton force-pushed the import_valid branch 2 times, most recently from af3f89a to c563b29 Compare May 5, 2022 06:02
@eileenmcnaughton
Copy link
Contributor Author

test this please

@seamuslee001 seamuslee001 merged commit 62394ea into civicrm:master May 5, 2022
@seamuslee001 seamuslee001 deleted the import_valid branch May 5, 2022 22:27
@eileenmcnaughton
Copy link
Contributor Author

thanks @seamuslee001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001