Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.50.alpha1.mysql.tpl - Escape grouping (reserved word in MySQL 8.0) #23396

Merged
merged 1 commit into from
May 6, 2022

Conversation

totten
Copy link
Member

@totten totten commented May 6, 2022

Overview

Upgrade from 5.49-stable to 5.50-rc fails on MySQL 8.0.

See also: https://dev.mysql.com/doc/refman/8.0/en/keywords.html#keywords-8-0-detailed-G

Before

$ cv upgrade:db -vv

...

Cleanup old files (CRM_Upgrade_Form::doFileCleanup(/Users/totten/.cv/upgrade/9b45b6ba86431b98dba8b6ebb3b9c813.dat))
Checking extensions (CRM_Upgrade_Form::disableOldExtensions(/Users/totten/.cv/upgrade/9b45b6ba86431b98dba8b6ebb3b9c813.dat))
Begin Upgrade to 5.50.alpha1 (CRM_Upgrade_Form::doIncrementalUpgradeStart(5.50.alpha1))
Upgrade DB to 5.50.alpha1 (CRM_Upgrade_Form::doIncrementalUpgradeStep(5.50.alpha1,5.49.1,5.50.beta1,/Users/totten/.cv/upgrade/9b45b6ba86431b98dba8b6ebb3b9c813.dat))
Upgrade DB to 5.50.alpha1: SQL (CRM_Upgrade_Incremental_php_FiveFifty::runSql(5.50.alpha1))
Cannot execute UPDATE civicrm_option_value
  SET grouping = 'case_type_id', description = NULL  WHERE option_group_id = @option_group_id_cgeo AND value = 'Case': DB Error: syntax error[bknix-max:~/bknix/build/wpmaster/web/wp-content/plugins/civicrm/civicrm]

After

Works

@civibot
Copy link

civibot bot commented May 6, 2022

(Standard links)

@civibot civibot bot added the master label May 6, 2022
@totten totten changed the base branch from master to 5.50 May 6, 2022 22:27
@civibot civibot bot added 5.50 and removed master labels May 6, 2022
@totten totten merged commit 60ec5fb into civicrm:5.50 May 6, 2022
@totten totten deleted the 5.50-upgrade-esc branch May 6, 2022 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants