dev/core#4190 Fix issue where defaultValues needs to be an array not … #25849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No issue was found matching the number given in the pull request title. Please check the issue number. |
|
(Standard links)
|
|
@eileenmcnaughton I thought about a type hint on the CRM_Core_Form function but then got scared as I thought it might mean I have to update all of them and there seems to be a lot in the CRM_ classes |
|
@seamuslee001 you can add return hints on child classes if they don't exist on the parent - but not vice versa - I have been doing that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…boolean
Overview
This fixes https://lab.civicrm.org/dev/core/-/issues/4190 by returning an array instead of boolean
Before
Case Delete fails on PHP8
After
Case Delete doesn't fail on PHP8
ping @eileenmcnaughton