dev/core#4189 Fix indiscriminate display of direct debit agreement #25910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No issue was found matching the number given in the pull request title. Please check the issue number. |
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
regression_dd
branch
from
da0f04f
to
7931a72
Compare
|
Works for me. I tested most of the scenarios as well, on 5.60rc:
There is a non-regression bug, which happened before: if there are multiple processors on the same form, the display of the "agreement" text depends on whether Direct Debit is set as the default processor. I think I've never noticed this agreement text before, because DD is never my default processor (global PP setting) |
|
I guess the non-regression bug might not be hit IRL too much |
|
#25918 WIP for the non-reggresion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
dev/core#4189 Fix indiscriminate display of direct debit agreement
Associated documentation update to encourage extension writers to provide their own text https://lab.civicrm.org/documentation/docs/dev/-/merge_requests/1065
Before
Direct debit text showing when it should not...
After
No longer showing for Dummy processor (I also tested in paylater mode but didn't screenshot)
Main Page
Confirm Page
Thank you page
Note to test Direct Debit I updated the Dummy Processor row to have payment_type = 2
Main Page
Confirm Page
Thank you (there is no agreement text on thank you)
Technical Details
Comments