Fix for membership discounts not showing in 5.62

[eileenmcnaughton]

Overview

Fix for membership discounts not showing in 5.62

Before

A membership configured per the screen shot automatically is applied for a renewing member in 5.61 but not 5.62

After

Functionality is returned

Technical Details

The issue is due to #24765

In 5.61 membership price sets had a value of 3 in the extends column and in 5.62 (after the upgrade is run as @kewljuice cleverly spotted) the value is no longer 3 but 3 wrapped in custom separators & hence the match is not made, the form is not identifed to the hook as a 'membership' form and civi-discount does not leap into action.

I put the change in a function ONLY called by this code patch because it is the rc but it should move to a more generic spot in the BAO_Order class in master. Also note I renamed the context function on the form as it is doing the same thing as one differently named on similar forms. The function is newly added in 5.61

Comments

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Jenkins re test this please

[composerjk]

A quick test of the patch added to a 5.62.0 install properly showed the automatic discount on the contribution page and the confirmation page. Only did a simple quick test of those two pages. fyi.

[kewljuice]

I added the patch and did some test(s), everything works again!

[totten]

Thanks @composerjk @kewljuice