CRM-19824 - Container::loadContainer - Always compile listeners #9617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the typical (cache-enabled) flow, the container is compiled to identify any services tagged with `kernel.event_subscriber`. However, if you disable caching, then it skipped compilation, and it failed to identify all the listeners. With this patch, we always detect the listeners -- even if caching is disabled. (This issue identified while working on tests for CRM-19690.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the typical (cache-enabled) flow, the container is compiled to identify
any services tagged with
kernel.event_subscriber. However, if you disablecaching, then it skipped compilation, and it failed to identify all the
listeners.
With this patch, we always detect the listeners -- even if caching is
disabled.
(This issue identified while working on tests for CRM-19690.