Fixed CRM-20292: removed permission checks for custom data caching in views #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… views. This breaks views unless there is an ACL in place if Drush CC is used on the command line.
|
Jenkins test this please |
|
Jenkins re test this please |
|
I had a chat with John FF about this and I agree with the change, It makes sense that this is the correct change and that it stabilizes behavior. @totten @eileenmcnaughton i believe this should get merged |
|
@totten @eileenmcnaughton any news? This has been ready for merge for around 2 months, is a 1 parameter change to ensure consistent behaviour. |
|
Ok - I'll merge based on @seamuslee001 review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the permission check breaks views with custom field, (they are broken even in the admin view), unless there is an ACL in place if Drush CC is used on the command line.
Saving any other view as an administrator fixed this.