Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jquery.tokeninput.js to 1.6.1 #336

Merged
merged 1 commit into from
Dec 12, 2021

Conversation

jitendrapurohit
Copy link
Contributor

@civibot
Copy link

civibot bot commented Dec 11, 2021

(Standard links)

@civibot civibot bot added the master label Dec 11, 2021
@colemanw
Copy link
Member

@jitendrapurohit I'm fine with merging this, but this package is no longer used anywhere in core. What prompted you to submit this?

@KarinG
Copy link

KarinG commented Dec 11, 2021

@colemanw - we ran into a bug with the autocomplete existing contact element in webform civicrm module -> which to date has been using this package. If it's no longer used in Core then maybe we should just handle this on our webform civicrm side of things?

@colemanw
Copy link
Member

colemanw commented Dec 12, 2021

@KarinG full circle :) Back in the early days of webfom-civicrm 2.x I required the libraries module and people had to go and download tokeninput.js themselves and add it to their sites/all/libraries directory. That was the "Drupal Way" at the time, and also a total PITA so I ended up scrapping that and had webform_civicrm just use the copy from CiviCRM - one less install gotcha. Then a few years later on the core-team side of things we ditched tokeninput.js in favor of Select2.js but for the sake of webform_civicrm users I never deleted the package from core.

But I think libraries are easier to manage now in D9. Maybe just require it in the webform_civcrm composer.json?

@colemanw
Copy link
Member

This is such a minor version bump, just 1.6.0 -> 1.6.1. Let's just merge it.

@colemanw colemanw merged commit 46e8efe into civicrm:master Dec 12, 2021
@KarinG
Copy link

KarinG commented Dec 12, 2021

🙂 Thank you! And yes I started looking at how eg better_exposed_filters module requires its js dependences.

@KarinG
Copy link

KarinG commented Mar 31, 2022

@colemanw would it be possible to port this back to 5.45.*

Because -> Jon's PR -> colemanw/webform_civicrm#680
Fails on 5.45 ->

image

@colemanw
Copy link
Member

Sorry there are no more releases planned for the 5.45 series.

@KarinG
Copy link

KarinG commented Mar 31, 2022

🤔 In the past ESR point releases post security updates have included backports of important fixes. I know b/c I've provided/tested some for previous ESRs.

@KarinG
Copy link

KarinG commented Mar 31, 2022

I can see the point that this does not amount to an important/critical fix.

@KarinG
Copy link

KarinG commented Apr 2, 2022

Solved by colemanw/webform_civicrm#729 [essentially removing any dependency on what ships/or not with CiviCRM Core]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants