-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jquery.tokeninput.js to 1.6.1 #336
Conversation
(Standard links)
|
@jitendrapurohit I'm fine with merging this, but this package is no longer used anywhere in core. What prompted you to submit this? |
@colemanw - we ran into a bug with the autocomplete existing contact element in webform civicrm module -> which to date has been using this package. If it's no longer used in Core then maybe we should just handle this on our webform civicrm side of things? |
@KarinG full circle :) Back in the early days of But I think libraries are easier to manage now in D9. Maybe just require it in the |
This is such a minor version bump, just 1.6.0 -> 1.6.1. Let's just merge it. |
🙂 Thank you! And yes I started looking at how eg better_exposed_filters module requires its js dependences. |
@colemanw would it be possible to port this back to 5.45.* Because -> Jon's PR -> colemanw/webform_civicrm#680 |
Sorry there are no more releases planned for the 5.45 series. |
🤔 In the past ESR point releases post security updates have included backports of important fixes. I know b/c I've provided/tested some for previous ESRs. |
I can see the point that this does not amount to an important/critical fix. |
Solved by colemanw/webform_civicrm#729 [essentially removing any dependency on what ships/or not with CiviCRM Core] |
Update jquery.tokeninput.js from https://github.com/loopj/jquery-tokeninput/releases/tag/v1.7.0