Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider behaviour when providing a value lower than 500 for bucket size #394

Closed
fernando-villalba opened this issue Apr 26, 2024 · 3 comments · Fixed by #470
Closed
Assignees

Comments

@fernando-villalba
Copy link
Contributor

Issue

The current behaviour when passing a value lower than 500 for bucket size is to ask this question:

Warning: The minimum size to create an object store is 500 GB. Would you like to create an object store of 500 GB? (y/n) ?

There are some issues with this approach

  1. It doesn't respect the --yes flag:
% civo bucket create --yes --size 50 test-ticket 
Warning: The minimum size to create an object store is 500 GB. Would you like to create an object store of 500 GB? (y/n) ?
  1. It should perhaps fail without asking anything.

If this command was part of a script, it would halt execution, if it fails, it's better.

  1. The help of the command needs to make it explicit that the minimum is 500, default is not the same as minimum, it should perhaps say default/minimum
-s, --size int                  Size of the Object store (default 500)

Acceptance criteria

There are two ways to tackle this

  • Fail lower values with a message that the minimum is 500, also change the help to explicitly say that the minimum is 500 --> preferred
  • Respect the --yes flag, and also change the help to explicitly say the minimum is 500
  • Automatically ignore lower values and assign 500 GBs, provide a warning when doing so --> This may give users the illusion they are paying less than they will if they are not paying attention, so perhaps not the best course of action.
@uzaxirr uzaxirr self-assigned this May 16, 2024
@harsh082ip
Copy link

Is there anyone working on this issue?
@fernando-villalba @uzaxirr

@harsh082ip
Copy link

If not, can you please assign it to me, I want to work on this

@harsh082ip
Copy link

harsh082ip commented Jul 9, 2024

I have made a PR regarding this issue.
Please review and let me know if any changes are needed.
@fernando-villalba @uzaxirr @RealHarshThakur @haardikdharma10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants