Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed version flag for k8s create #294

Merged
merged 2 commits into from
Jan 10, 2023
Merged

Renamed version flag for k8s create #294

merged 2 commits into from
Jan 10, 2023

Conversation

satakshigarg
Copy link
Contributor

Version flag doesn't appear civo kubernetes create --help command.
Signed-off-by: satakshigarg satakshi@civo.com

Renamed version flag for k8s create
9ade3a8 
Signed-off-by: satakshigarg <satakshi@civo.com>
@satakshigarg satakshigarg self-assigned this Jan 9, 2023
alessandroargentieri
alessandroargentieri requested changes Jan 9, 2023
View reviewed changes
Copy link
Member

@alessandroargentieri alessandroargentieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version command in civo kubernetes create is missing in the docs because the civo --version flag is wrongly declared as a persistent flag, which means a flag that has the same behaviour at every level.

cmd/kubernetes/kubernetes.go Outdated Show resolved Hide resolved
Converted version to non-global flag
cd11798 
Signed-off-by: satakshigarg <satakshi@civo.com>
alessandroargentieri
alessandroargentieri approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@alessandroargentieri alessandroargentieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alessandroargentieri alessandroargentieri merged commit bbaa2d1 into master Jan 10, 2023
@satakshigarg satakshigarg deleted the Create_k8_version_flag branch January 11, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessandroargentieri alessandroargentieri alessandroargentieri approved these changes

Assignees

@satakshigarg satakshigarg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@satakshigarg @alessandroargentieri