Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conditions to cluster show and list commands #324

Merged
merged 3 commits into from
Jul 3, 2023

Conversation

haardikdharma10
Copy link
Contributor

Description

Adds the following conditions to cluster show and list commands -

  1. Control Plane is accessible.
  2. Worker Nodes are up.
  3. Cluster is on desired version.

This will solve user's confusion about what's happening with their clusters i.e "Is my cluster scaling up?" , "Is control plane unresponsive?", "Is cluster upgrading?",etc.

@alejandrojnm
Copy link
Member

Can you put and example of the output here ???

@haardikdharma10
Copy link
Contributor Author

Screenshot 2023-06-29 at 17 28 53

Screenshot 2023-06-29 at 17 28 36

Copy link
Member

@alejandrojnm alejandrojnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haardikdharma10 haardikdharma10 merged commit cc3cc6d into master Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants