Aliases for DB software #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmd/database/database_create.go
Outdated
| if softwareVersion == "" && software == "MySQL" { | ||
| softwareVersion = "8.0" | ||
| validSoftwares := map[string][]string{ | ||
| "mysql": {"mysql", "my", "sql"}, |
There was a problem hiding this comment.
I don't think we should allow "my" and "sql"
cmd/database/database_create.go
Outdated
| os.Exit(1) | ||
| } | ||
|
|
||
| if !softwareVersionIsValid { | ||
| utility.Error("The provided software version is not valid") | ||
| if softwareVersion == "" { | ||
| utility.Error(fmt.Sprintf("No version specified for %s. Please provide a version using --version flag. For example, civo database create db-psql --software psql --version 14.", canonicalSoftwareName)) |
There was a problem hiding this comment.
please remove the .
cmd/database/database_create.go
Outdated
| } | ||
| } | ||
|
|
||
| if !softwareIsValid { | ||
| utility.Error("The provided software name is not valid. Make sure you use correct capitalization (e.g. MySQL, PostgreSQL)") | ||
| utility.Error("The provided software name is not valid. Make sure you use correct capitalization (e.g., MySQL, PostgreSQL)") |
There was a problem hiding this comment.
please remove comma
fernando-villalba
requested changes
May 17, 2024
cmd/database/database_create.go
Outdated
| } | ||
| } | ||
|
|
||
| if !softwareIsValid { | ||
| utility.Error("The provided software name is not valid. Make sure you use correct capitalization (e.g. MySQL, PostgreSQL)") | ||
| utility.Error("The provided software name is not valid. Make sure you use correct capitalization (eg: MySQL, PostgreSQL)") |
There was a problem hiding this comment.
I am confused, if the change was to allow the usage of lowercase names of the database (ideally case insensitive) why do we still have this error asking for correct capitalization?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #395
