Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show dangling volume info only when required. #423

Merged
merged 3 commits into from
May 17, 2024
Merged

Show dangling volume info only when required. #423

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
00e029c
change err msg
uzaxirr May 17, 2024
b0140da
Revert "change err msg"
uzaxirr May 17, 2024
8be2fcf
Show dangling volume info only when required.
uzaxirr May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion cmd/volume/volume_list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,18 @@ Example: civo volume ls -o custom -f "ID: Name (SizeGigabytes)`,
return volumes[i].Name < volumes[j].Name
})

utility.Info("Volumes with status 'dangling' mean they are attached to a cluster that no longer exists. You can attach them to an instance, or delete them if they are no longer needed.")
hasDanglingVolumes := false
for _, volume := range volumes {
if volume.Status == "dangling" {
hasDanglingVolumes = true
break
}
}

if hasDanglingVolumes {
utility.Info("Volumes with status 'dangling' mean they are attached to a cluster that no longer exists. You can attach them to an instance, or delete them if they are no longer needed.")
}

for _, volume := range volumes {
ow.StartLine()
ow.AppendDataWithLabel("id", volume.ID, "ID")
Expand Down
Loading