Add a StateChange to the firewall to wait for network be ready. (#169)

civo/resource_firewall.go

@@ -131,9 +131,31 @@ func resourceFirewallCreate(ctx context.Context, d *schema.ResourceData, m inter
 		return diag.Errorf("[ERR] an error occurred while trying to build the firewall request, %s", err)
 	}
 
-	firewall, err := apiClient.NewFirewall(firewallConfig)
+	// Create StateChangeConf to wait for the firewall to be created
+	createStateConf := &resource.StateChangeConf{
+		Pending: []string{"failed"},
+		Target:  []string{"success"},
+		Refresh: func() (interface{}, string, error) {
+			resp, err := apiClient.NewFirewall(firewallConfig)
+			if err != nil {
+				return 0, "", err
+			}
+			return resp, string(resp.Result), nil
+		},
+		Timeout:        60 * time.Minute,
+		Delay:          3 * time.Second,
+		MinTimeout:     3 * time.Second,
+		NotFoundChecks: 10,
+	}
+	_, err = createStateConf.WaitForStateContext(context.Background())
+	if err != nil {
+		return diag.Errorf("[ERR] failed to create a new firewall: %s, err: %s", firewallConfig.Name, err)
+	}
+
+	// Get the firewall
+	firewall, err := apiClient.FindFirewall(firewallConfig.Name)
 	if err != nil {
-		return diag.Errorf("[ERR] failed to create a new firewall: %s", err)
+		return diag.Errorf("[ERR] error retrieving firewall: %s, err: %s", firewallConfig.Name, err)
 	}
 
 	d.SetId(firewall.ID)

civo/resource_firewall_test.go

@@ -176,7 +176,7 @@ func testAccCheckCivoFirewallConfigBasic(name string) string {
 resource "civo_firewall" "foobar" {
 	name = "%s"
 	create_default_rules = true
-	region = "FAKE"
+	region = "LOCAL"
 }`, name)
 }
 
@@ -185,7 +185,7 @@ func testAccCheckCivoFirewallConfigWithIngressEgress(name string) string {
 resource "civo_firewall" "foobar" {
 	name = "%s"
 	create_default_rules = false
-	region = "FAKE"
+	region = "LOCAL"
 
 	ingress_rule {
 		label = "www https"
@@ -210,6 +210,6 @@ func testAccCheckCivoFirewallConfigUpdates(name string) string {
 resource "civo_firewall" "foobar" {
 	name = "%s"
 	create_default_rules = true
-	region = "FAKE"
+	region = "LOCAL"
 }`, name)
 }