[BUG] When using tilde ~ on credentials_file it does not expand to home directory

[fernando-villalba]

Description

Using tilde for the home directory in the configuration for credentials_file does not work:

provider "civo" {
  region = "LON1"
  credentials_file = "~/token"
}

This is because os.ReadFile(path) does not expand the tilde.

Proposed solution

We can use the go-homedir function here is an example

Any other solution with minimal code required would do, there is a built-in function called os/user but according to Mitchell Hashimoto, the create of the go-homedir function above:

Why not just use os/user? The built-in os/user package requires cgo on Darwin systems. This means that any Go code that uses that package cannot cross compile. But 99% of the time the use for os/user is just to retrieve the home directory, which we can do for the current user without cgo. This library does that, enabling cross-compilation.

Or that was the case 6 years ago, it may be different today, haven't done the research.

Acceptance Criteria

• Ensure that the tilde (~) gets expanded properly. Don't use too much code for this.

[Praveen005]

Hi @fernando-villalba,

homedir.Expand() works well for our use case. As for os/user, it doesn't directly help us expand tilde (~).

I tested the change and it works fine.

[Praveen005]

Hi @uzaxirr

#322 fixes this as well.

I used homedir.Expand() to expand the tilde.

Reason:

1. The current version is stable.
2. It was wide adoption.
3. homedir itself doesn't depend on any other third-party library.
4. Currently we are also using it in our Civo CLI repository.

https://github.com/civo/cli/blob/8a5fa361e070a817a5d07d71d582badf9a274f38/config/config.go#L48

Result:

Before:
Throwing error:

After:

works fine:

[uzaxirr]

Resolved via: #322