Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate existence and structure of credentials_file #322

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

Praveen005
Copy link
Contributor

This PR fixes #316

In here, I:

  • Added checks for the existence of the credentials_file provided by the user.
  • Validated the correct data structure of the token file.
  • Implemented a file size limit check to prevent issues with excessively large files.

Result:
Some error scenarios:

Screenshot 2024-08-14 171933 Screenshot 2024-08-14 171800 Screenshot 2024-08-14 171751 Screenshot 2024-08-14 171703 Screenshot 2024-08-14 171630 Screenshot 2024-08-14 171525

- Added checks for the existence of the credentials_file provided by the user.
- Validated the correct data structure of the token file.
- Implemented a file size limit check to prevent issues with excessively large files.
Copy link
Member

@uzaxirr uzaxirr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commendable work!

@uzaxirr uzaxirr merged commit cbb74fb into civo:master Aug 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] We need to validate the existence of the file and correct data structure of the token file
2 participants