Add CIDR and Nameservers support in network #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
uzaxirr
commented
Mar 28, 2024
uzaxirr
commented
|
The IP is not the same, is problem with the api or in the UI??? |
Its a UI Problem |
alessandroargentieri
requested changes
Mar 28, 2024
civo/network/resource_network.go
Outdated
| @@ -30,6 +30,19 @@ func ResourceNetwork() *schema.Resource { | |||
| Computed: true, | |||
| Description: "The region of the network", | |||
| }, | |||
| "cidr": { | |||
There was a problem hiding this comment.
can we get it named cidr_v4 like we have in the api? Because In the future we will have cidr_v6
There was a problem hiding this comment.
we can add cidr_v6 in the future because we assume cidr alone is ipv4
civo/network/resource_network.go
Outdated
| Optional: true, | ||
| Description: "The CIDR block for the network", | ||
| }, | ||
| "nameservers": { |
There was a problem hiding this comment.
can we get it named nameservers_v4 like we have in the api? Because In the future we will have nameservers_v6
There was a problem hiding this comment.
same as the cidr, nameserver alone is ipv4 and the other one is ipv6
alessandroargentieri
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.