Wait for the instance to be completely deleted

[uzaxirr]

Fixes: #252

To address this issue, we can implement dependencies explicitly in the Terraform configuration using the depends_on argument. This argument will make sure the reserved IP is destroyed after the instance.

provider "civo" {
  region = "LON1"
}

resource "civo_reserved_ip" "www" {
  name = "test-ip2"
}

resource "civo_instance" "foo" {
  hostname = "amazingthingy20"
  tags = ["python", "nginx"]
  notes = "This is a test-issue"
  size = "g3.xsmall"
  region = "LON1"
  reserved_ipv4 = civo_reserved_ip.www.id
  firewall_id = "default-default"
  disk_image = "debian-10"

  depends_on = [civo_reserved_ip.www]
}

Also i've made changes in the provider to ensure that when an instance is deleted, it properly waits for the deletion to be completed this will solve the issue

[fernando-villalba]

Looks good to me, but make sure you test it with a few different destroying scenarios to ensure it doesn't make destroying operations too long in some cases.

[uzaxirr]

Looks good to me, but make sure you test it with a few different destroying scenarios to ensure it doesn't make destroying operations too long in some cases.

Yes, I have tested it locally before raising the PR