fix: remove unnecessary retries and improve error handling #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uzaxirr
approved these changes
Jul 23, 2024
|
Amazing work, thank you for the PR |
|
Thank you @uzaxirr! Looking forward to contributing more. |
|
@Praveen005 really amazing work! Thank you so much! |
|
Thank you @fernando-villalba. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #263
Fixes: #256
fixes: #269
fixes: #271
fixes: #273
fixes: #270
Now we directly return the error received from the API, instead of retrying.
I have also added functions to parse the error received and return only the error code and associated message to the user.
It also fixes issues: 256, 249, 269, 271, 273.
This will likely fix 270 as well.
Screenshots from the Result:
Issue 263:
Issue 256:
Issue 249:
Issue 269:
Issue 271:
Issue 273: