Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow updating kubernetes_version after cluster creation #276

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

Praveen005
Copy link
Contributor

This PR fixes #261

Screenshots:

Current Behaviour:

Says modification applied:

Screenshot 2024-07-23 145531

But cluster's state remains the same:

Screenshot 2024-07-23 145656

main.tf:

Screenshot 2024-07-23 145633

After changes:

Cluster updating:

Screenshot 2024-07-23 150438

Cluster updated with a new kubernetes_version:

Screenshot 2024-07-23 150610

@uzaxirr
Copy link
Member

uzaxirr commented Jul 23, 2024

@alejandrojnm can you review this

Copy link
Member

@uzaxirr uzaxirr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work as always!

@uzaxirr uzaxirr merged commit 16c018b into civo:master Jul 23, 2024
1 check passed
@Praveen005
Copy link
Contributor Author

Thank you @uzaxirr :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Changing kubernetes_version after creation for civo_kubernetes_cluster does nothing
3 participants