Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cluster primary nodepool scaling bug #63

Merged
merged 2 commits into from
Aug 18, 2021
Merged

Fix cluster primary nodepool scaling bug #63

merged 2 commits into from
Aug 18, 2021

Conversation

zulh-civo
Copy link
Member

Closes #52

Also added a validation for num_target_nodes field. Only positive number should be accepted moving forward.

Example error when user provide 0 or negative number:

Screenshot 2021-08-17 at 10 19 48 AM

@zulh-civo zulh-civo self-assigned this Aug 17, 2021
alejandrojnm
alejandrojnm requested changes Aug 18, 2021
View reviewed changes
civo/resource_kubernetes_cluster.go Outdated Show resolved Hide resolved
@zulh-civo
Copy link
Member Author

I have replaced the custom validator for num_target_nodes field to use validate.IntAtLeast(1) (doc) as suggested by @alejandrojnm.

Here is the error message when user provide 0 or less.

Screenshot 2021-08-18 at 10 19 51 AM

@zulh-civo zulh-civo merged commit 6d4088f into civo:master Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejandrojnm alejandrojnm alejandrojnm approved these changes

@saiyam1814 saiyam1814 Awaiting requested review from saiyam1814

Assignees

@zulh-civo zulh-civo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

civo_kubernetes_cluster scale up is not working as expected
2 participants
@zulh-civo @alejandrojnm